chia7712 commented on code in PR #20203:
URL: https://github.com/apache/kafka/pull/20203#discussion_r2483742532
##########
core/src/main/scala/kafka/server/BrokerServer.scala:
##########
@@ -283,6 +286,13 @@ class BrokerServer(
remoteLogManagerOpt = createRemoteLogManager(listenerInfo)
+ remoteLogManagerOpt.foreach(rlm =>
+ rlm.remoteLogMetadataManager() match {
+ case callback: BrokerReadyCallback =>
registerBrokerReadyCallback(callback)
Review Comment:
If we keep the callbacks as a collection, it must be cleared in `shutdown`.
Since we often call `shutdown` and `startup` to reboot embedded kafka
instances, this is another argument against using a collection here :smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
