kamalcph commented on code in PR #20203:
URL: https://github.com/apache/kafka/pull/20203#discussion_r2481491569
##########
server-common/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/BrokerReadyCallback.java:
##########
@@ -14,16 +14,16 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-
-package org.apache.kafka.storage.internals.log;
-
-import org.apache.kafka.common.requests.FetchRequest.PartitionData;
+package org.apache.kafka.server.log.remote.metadata.storage;
/**
- * A class containing log offset metadata and fetch info for a topic partition.
+ * Callback interface for broker ready notification.
*/
-public record FetchPartitionStatus(
- LogOffsetMetadata startOffsetMetadata,
- PartitionData fetchInfo
-) {
+public interface BrokerReadyCallback {
Review Comment:
Please move this class from `server-common` to `storage` module
##########
core/src/main/scala/kafka/server/BrokerServer.scala:
##########
@@ -162,6 +163,8 @@ class BrokerServer(
var persister: Persister = _
+ private val brokerReadyCallbacks = new
mutable.ListBuffer[BrokerReadyCallback]()
Review Comment:
shall we use `util.ArrayList` instead? Kafka codebase is being rewritten to
Java.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
