chia7712 commented on code in PR #20203:
URL: https://github.com/apache/kafka/pull/20203#discussion_r2480325128


##########
core/src/main/scala/kafka/server/BrokerServer.scala:
##########
@@ -591,6 +600,15 @@ class BrokerServer(
         "all of the SocketServer Acceptors to be started",
         enableRequestProcessingFuture, startupDeadline, time)
 
+      brokerReadyCallbacks.foreach { callback =>
+        try {
+          callback.onBrokerReady()

Review Comment:
   > The BrokerReadyCallback interface is not part of public API, then should 
this be moved away from org.apache.kafka.server.common package server-common to 
storage module?
   
   good point! @jiafu1115 would you mind addressing it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to