chia7712 commented on code in PR #20390:
URL: https://github.com/apache/kafka/pull/20390#discussion_r2318235635
##########
tests/kafkatest/services/verifiable_consumer.py:
##########
@@ -424,7 +424,7 @@ def start_cmd(self, node):
if self.max_messages > 0:
cmd += " --max-messages %s" % str(self.max_messages)
- cmd += " --consumer.config %s" % VerifiableConsumer.CONFIG_FILE
+ cmd += " --command-config %s" % VerifiableConsumer.CONFIG_FILE
Review Comment:
this breaks `consumer_protocol_migration_test.py`
##########
tests/kafkatest/services/verifiable_producer.py:
##########
@@ -249,7 +249,7 @@ def start_cmd(self, node, idx):
if self.repeating_keys is not None:
cmd += " --repeating-keys %s " % str(self.repeating_keys)
- cmd += " --producer.config %s" % VerifiableProducer.CONFIG_FILE
+ cmd += " --command-config %s" % VerifiableProducer.CONFIG_FILE
Review Comment:
this change could break the `compatibility_test_new_broker_test.py`, since
the `VerifiableProducer` is running under old kafka.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
