AndrewJSchofield commented on code in PR #20390:
URL: https://github.com/apache/kafka/pull/20390#discussion_r2301020026
##########
tools/src/main/java/org/apache/kafka/tools/VerifiableProducer.java:
##########
@@ -189,6 +190,14 @@ private static ArgumentParser argParser() {
.dest("repeatingKeys")
.help("If specified, each produced record will have a key starting
at 0 increment by 1 up to the number specified (exclusive), then the key is set
to 0 again");
+ parser.addArgument("--command-config")
+ .action(store())
+ .required(false)
+ .type(String.class)
+ .metavar("CONFIG-FILE")
+ .dest("commandConfigFile")
+ .help("Config properties file.");
Review Comment:
And here `(config options shared with command line parameters will be
overridden)`.
##########
tools/src/main/java/org/apache/kafka/tools/VerifiableConsumer.java:
##########
@@ -611,8 +611,17 @@ private static ArgumentParser argParser() {
.action(store())
.required(false)
.type(String.class)
- .metavar("CONFIG_FILE")
- .help("Consumer config properties file (config options shared
with command line parameters will be overridden).");
+ .metavar("CONFIG-FILE")
+ .help("(DEPRECATED) Consumer config properties file (config
options shared with command line parameters will be overridden)." +
+ "This option will be removed in a future version. Use
--command-config instead.");
+
+ parser.addArgument("--command-config")
+ .action(store())
+ .required(false)
+ .type(String.class)
+ .metavar("CONFIG-FILE")
+ .dest("commandConfigFile")
+ .help("Config properties file.");
Review Comment:
I suggest adding `(config options shared with command line parameters will
be overridden)` to the help string. That's still true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
