lucasbru commented on PR #19400:
URL: https://github.com/apache/kafka/pull/19400#issuecomment-3227552232
@mjsax Not sure - the default for the consumer was to leave the group for
dynamic members, so I think the example is correct? We just need to make sure
that Kafka Streams will use `REMAIN_IN_GROUP` by default, which I suppose this
PR is doing.
But I'm also confused. In KIP-1092, I see this:
```
* {@code LEAVE_GROUP} means the consumer will leave the group.
* {@code REMAIN_IN_GROUP} means the consumer will remain in the
group.
* {@code DEFAULT} applies the default behavior, which may depend on
whether the consumer is static or dynamic.
```
This seems clear. But in the new consumer code, a different behavior seems
to be documented, see
https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerMembershipManager.java#L431-L436
```
- Default operation: both static and dynamic consumers will send a leave
heartbeat
- Leave operation: both static and dynamic consumers will send a leave
heartbeat
- Remain in group: only static consumers will send a leave heartbeat, while
dynamic members will not
```
???
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
