mjsax commented on PR #19400:
URL: https://github.com/apache/kafka/pull/19400#issuecomment-3225700806
I was just cycling back to the KIP. There is the following example:
```
// Old usage
consumer.close(Duration.ofSeconds(30));
// New usage
consumer.close(CloseOptions.timeout(Duration.ofSeconds(30))
.withGroupMembershipOperation(GroupMembershipOperation.DEFAULT));
// New usage (shorter version)
consumer.close(CloseOptions.timeout(Duration.ofSeconds(30)));
```
It seems this example is not correct? The behavior of the existing `close()`
and `close(Duration)` should not change, and they would never send a
leave-group-request (for both dynamic, and static case) from my understanding.
Thus, for dynamic member, the new usage would need to pass `REMAIN_IN_GROUP` to
get the same behavior?
Thinking about this further, we could include a change of default behavior
for `close()` and `close(Duration)` in the KIP, but only apply it in AK 5.0. We
cannot apply it in a minor release... Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
