jsancio commented on code in PR #20242:
URL: https://github.com/apache/kafka/pull/20242#discussion_r2301913218
##########
core/src/main/scala/kafka/server/ControllerServer.scala:
##########
Review Comment:
Please remove the changes to this file.
##########
core/src/main/scala/kafka/server/BrokerServer.scala:
##########
Review Comment:
Please remove the changes to this file.
##########
core/src/main/scala/kafka/server/KafkaRequestHandler.scala:
##########
Review Comment:
Please remove the changes to this file.
##########
core/src/main/scala/kafka/tools/TestRaftServer.scala:
##########
Review Comment:
Please remove the changes to this file.
##########
metadata/src/main/java/org/apache/kafka/image/TopicsDelta.java:
##########
@@ -136,6 +136,7 @@ public String replay(RemoveTopicRecord record) {
String topicName;
if (topicDelta != null) {
topicName = topicDelta.image().name();
+ createdTopics.remove(topicName);
Review Comment:
Looks like this record should also delete the topic from `changedTopics`.
The methods `replay(TopicRecord)` and `getOrCreateTopicDelta(Uuid)` add entries
to that map which need to get removed if the topic has been deleted in this
delta.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
