jsancio commented on code in PR #20242:
URL: https://github.com/apache/kafka/pull/20242#discussion_r2301879200
##########
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##########
@@ -5335,6 +5335,16 @@ class ReplicaManagerTest {
delta
}
+ @Test
+ def testTopicsDeltaCreateThenDelete(): Unit ={
+ val delta = topicsCreateDelta(0, isStartIdLeader = true, partitions =
List(0), topicName = topic, topicId = FOO_UUID)
+ assertEquals(delta.createdTopicIds().contains(FOO_UUID),true)
+ assertEquals(delta.deletedTopicIds().contains(FOO_UUID),false)
+ delta.replay(new RemoveTopicRecord().setTopicId(FOO_UUID))
+ assertEquals(delta.deletedTopicIds().contains(FOO_UUID),false)
+ assertEquals(delta.createdTopicIds().contains(FOO_UUID),false)
Review Comment:
Thanks. This test fails against trunk for me.
Is there a reason why this test was added in `ReplicaManagerTest`? If
possible, lets add this test in `TopicsImageTest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
