chia7712 commented on code in PR #20394:
URL: https://github.com/apache/kafka/pull/20394#discussion_r2296227006
##########
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManager.java:
##########
@@ -314,6 +314,8 @@ private void removeMetrics() {
metricsGroup.removeMetric(REMOTE_LOG_MANAGER_TASKS_AVG_IDLE_PERCENT_METRIC);
metricsGroup.removeMetric(REMOTE_LOG_READER_FETCH_RATE_AND_TIME_METRIC);
remoteStorageReaderThreadPool.removeMetrics();
+ Utils.closeQuietly(fetchQuotaMetrics, "fetchQuotaMetrics");
Review Comment:
@jim0987795064 Could you please add unit test for it? `RemoteLogManagerTest`
would be a good place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
