kamalcph commented on code in PR #20394:
URL: https://github.com/apache/kafka/pull/20394#discussion_r2294023162
##########
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManager.java:
##########
@@ -2054,6 +2054,8 @@ public void close() {
Utils.closeQuietly(indexCache, "RemoteIndexCache");
Utils.closeQuietly(remoteLogMetadataManagerPlugin,
"remoteLogMetadataManagerPlugin");
Utils.closeQuietly(remoteStorageManagerPlugin,
"remoteStorageManagerPlugin");
+ Utils.closeQuietly(fetchQuotaMetrics, "fetchQuotaMetrics");
+ Utils.closeQuietly(copyQuotaMetrics, "copyQuotaMetrics");
Review Comment:
minor suggestions:
shall we move these 2 lines to RemoteLogManager#removeMetrics() method? And,
call RemoteLogManager#removeMetrics() at the end after closing
`remoteStorageManagerPlugin`.
Also, can the try..finally block be updated?
```java
public void close() {
synchronized (this) {
if (!closed) {
try {
..
..
closed = true;
} finally {
removeMetrics();
}
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
