kamalcph commented on code in PR #20342:
URL: https://github.com/apache/kafka/pull/20342#discussion_r2290417448
##########
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManager.java:
##########
@@ -2050,10 +2047,13 @@ public void close() {
} finally {
Review Comment:
The wait time is set to 10 seconds. The
[ThreadUtils#shutdownExecutorServiceQuietly](https://sourcegraph.com/github.com/apache/kafka/-/blob/clients/src/main/java/org/apache/kafka/common/utils/ThreadUtils.java?L95)
waits twice during `shutdown` and `shutdownNow` operations.
The copy/expiration/follower tasks were already cancelled with interrupt set
to true. Those are broker background operations. We can also make it graceful
but it can delay the server shutdown time if the remote storage is slow.
The RemoteStorageReaderThreadPool which handles the client RemoteFetch
requests also waits for 10 seconds. Shall we bump this to 30 seconds?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
