kamalcph commented on code in PR #20342:
URL: https://github.com/apache/kafka/pull/20342#discussion_r2290429757


##########
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManager.java:
##########
@@ -2050,10 +2047,13 @@ public void close() {
                 } finally {
                     removeMetrics();
                 }
-
                 leaderCopyRLMTasks.clear();
                 leaderExpirationRLMTasks.clear();
                 followerRLMTasks.clear();
+
+                Utils.closeQuietly(indexCache, "RemoteIndexCache");

Review Comment:
   Followed caller -> callee pattern.  RemoteIndexCache invokes 
remoteStorageManagerPlugin to fetch the indexes so changed the shutdown order.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to