chia7712 commented on code in PR #20349: URL: https://github.com/apache/kafka/pull/20349#discussion_r2275684621
########## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/log/TestLinearWriteSpeed.java: ########## @@ -222,16 +222,19 @@ public static void main(String[] args) throws Exception { private static void setupCompression(CompressionType compressionType, Compression.Builder<? extends Compression> compressionBuilder, - int compressionLevel) { + Integer compressionLevel) { Review Comment: Perhaps we could call `setupCompression` only if `compressionLevel` is defined. WDYT? ```java if (compressionLevel != null) setupCompression(compressionType, compressionBuilder, compressionLevel); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org