mimaison commented on code in PR #20349:
URL: https://github.com/apache/kafka/pull/20349#discussion_r2273276617
##########
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/log/TestLinearWriteSpeed.java:
##########
@@ -143,6 +143,9 @@ public static void main(String[] args) throws Exception {
int compressionLevel = options.valueOf(compressionLevelOpt);
setupCompression(compressionType, compressionBuilder,
compressionLevel);
+ final Compression compression = compressionBuilder.build();
+
+ System.out.printf("Using compression=%s level=%d%n",
compressionType.name, compressionLevel);
Review Comment:
Did you intend to add this message? We don't log any of the other configs.
##########
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/log/TestLinearWriteSpeed.java:
##########
@@ -143,6 +143,9 @@ public static void main(String[] args) throws Exception {
int compressionLevel = options.valueOf(compressionLevelOpt);
setupCompression(compressionType, compressionBuilder,
compressionLevel);
+ final Compression compression = compressionBuilder.build();
Review Comment:
We typically don't declare local variables as `final`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
