showuon commented on code in PR #20237:
URL: https://github.com/apache/kafka/pull/20237#discussion_r2250298473


##########
docs/ops.html:
##########
@@ -4498,9 +4498,16 @@ <h4 class="anchor-heading"><a 
id="eligible_leader_replicas_upgrade" class="ancho
   <p>Downgrades are safe to perform by setting 
<code>eligible.leader.replicas.version=0</code>.</p>
 
   <h4 class="anchor-heading"><a id="eligible_leader_replicas_tool" 
class="anchor-link"></a><a href="#eligible_leader_replicas_tool">Tool</a></h4>
-  <p>The ELR fields can be checked through the API DescribeTopicPartitions. 
The admin client can fetch the ELR info by describing the topics.
-    Also note that, if <code>min.insync.replicas</code> is updated for a 
topic, the ELR field will be cleaned. If cluster default min ISR is updated,
-    all the ELR fields will be cleaned.</p>
+  <p>The ELR fields can be checked through the API DescribeTopicPartitions. 
The admin client can fetch the ELR info by describing the topics.</p>
+  <p>Note that when the ELR feature is enabled:</p>
+  <ul>
+    <li>The cluster-level <code>min.insync.replicas</code> config will be 
added if there is not any. The value is the same as the static config in the 
active controller.</li>
+    <li>The removal of <code>min.insync.replicas</code> config in 
cluster-level is not allowed.</li>

Review Comment:
   Updated in the commit: 
https://github.com/apache/kafka/pull/20237/commits/70957737e845eb2f2addbd7578433ffbe69fb6e0.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to