showuon commented on code in PR #20237: URL: https://github.com/apache/kafka/pull/20237#discussion_r2244259481
########## docs/ops.html: ########## @@ -4499,8 +4499,15 @@ <h4 class="anchor-heading"><a id="eligible_leader_replicas_upgrade" class="ancho <h4 class="anchor-heading"><a id="eligible_leader_replicas_tool" class="anchor-link"></a><a href="#eligible_leader_replicas_tool">Tool</a></h4> <p>The ELR fields can be checked through the API DescribeTopicPartitions. The admin client can fetch the ELR info by describing the topics. - Also note that, if <code>min.insync.replicas</code> is updated for a topic, the ELR field will be cleaned. If cluster default min ISR is updated, - all the ELR fields will be cleaned.</p> + Note that when the ELR feature is enabled: + <ul> + <li>The override of <code>min.insync.replicas</code> in broker-level will be removed.</li> + <li>The alter of <code>min.insync.replicas</code> config in broker-level is not allowed.</li> + <li>The removal of <code>min.insync.replicas</code> config in cluster-level is not allowed.</li> + <li>If <code>min.insync.replicas</code> is updated for a topic, the ELR field will be cleaned.</li> Review Comment: It means the ELR state in the controller side will be empty(reset) because the new updated min ISR makes the existing ELR state invalid. @CalvinConfluent , is my understanding correct? Is it hard to understand for users? Maybe change to `If <code>min.insync.replicas</code> is updated for a topic, the ELR state will be reset.`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
