AndrewJSchofield commented on PR #19796: URL: https://github.com/apache/kafka/pull/19796#issuecomment-2939185426
> @AndrewJSchofield I tried to add an integration test. However, the `GroupMetadataManager` doesn't support to use other assignors for share groups. Currently, there is no usage of `withShareGroupAssignor` in production code, so it can only use `SimpleAssignor`. > > The consumer group uses `group.consumer.assignors` to define assignors. Do we want to add a new config `group.share.assignors` for share group? I can add this in the next PR. Thanks. > > https://github.com/apache/kafka/blob/b1ea280ab1012e857d4c8354fc57951f9c88f667/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java#L351-L354 > > https://github.com/apache/kafka/blob/b1ea280ab1012e857d4c8354fc57951f9c88f667/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java#L374-L375 Ah, yes, good catch. We missed this config. I have created a specific issue https://issues.apache.org/jira/browse/KAFKA-19369. Given that KIP-932 does not permit a list of assignors, the only thing a user could do is implement their own assignor and replace the simple one. We've essentially hard-coded the `SimpleAssignor` with no way to override it. When we add more assignors in the future, the plan was to enhance the support for this config to support a list, just as for consumer groups. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
