AndrewJSchofield commented on code in PR #19796:
URL: https://github.com/apache/kafka/pull/19796#discussion_r2121522059
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -2569,16 +2565,15 @@ private
CoordinatorResult<Map.Entry<ShareGroupHeartbeatResponseData, Optional<In
numMembers
);
- if (!subscriptionMetadata.equals(group.subscriptionMetadata())) {
- log.info("[GroupId {}] Computed new subscription metadata:
{}.",
- groupId, subscriptionMetadata);
+ if (groupMetadataHash != group.metadataHash()) {
+ log.info("[GroupId {}] Computed new metadata hash: {}.",
+ groupId, groupMetadataHash);
bumpGroupEpoch = true;
- records.add(newShareGroupSubscriptionMetadataRecord(groupId,
subscriptionMetadata));
}
if (bumpGroupEpoch) {
groupEpoch += 1;
- records.add(newShareGroupEpochRecord(groupId, groupEpoch, 0));
+ records.add(newShareGroupEpochRecord(groupId, groupEpoch,
groupMetadataHash));
log.info("[GroupId {}] Bumped group epoch to {}.", groupId,
groupEpoch);
Review Comment:
nit: This log includes the metadata hash in consumer groups. Seems sensible
here too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
