dajac commented on code in PR #19761:
URL: https://github.com/apache/kafka/pull/19761#discussion_r2111672498
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -490,6 +490,13 @@ GroupMetadataManager build() {
*/
private MetadataImage metadataImage;
+ /**
+ * The cache for topic hash value by topic name.
+ * A topic hash is calculated when there is a group subscribes to it.
+ * A topic hash is removed when it's updated in MetadataImage or there is
no group subscribes to it.
+ */
+ private final Map<String, Long> topicHashCache;
Review Comment:
I was thinking that we may want to keep a reference to the image within that
class. We could basically have something like `void
onNewMetadataImage(MetadataImage newImage, MetadataDelta delta)` and handle the
updated via it. It was just an idea though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
