FrankYang0529 commented on code in PR #19761:
URL: https://github.com/apache/kafka/pull/19761#discussion_r2111488459
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -490,6 +490,13 @@ GroupMetadataManager build() {
*/
private MetadataImage metadataImage;
+ /**
+ * The cache for topic hash value by topic name.
+ * A topic hash is calculated when there is a group subscribes to it.
+ * A topic hash is removed when it's updated in MetadataImage or there is
no group subscribes to it.
+ */
+ private final Map<String, Long> topicHashCache;
Review Comment:
It's a good idea. I will create a Jira later. I have one question: why we
need a method to update the `MetadataImage`. Do we want to include the hash in
`MetadataImage`? Or you want to say `metadataHash` here? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
