apoorvmittal10 commented on code in PR #19612: URL: https://github.com/apache/kafka/pull/19612#discussion_r2071349955
########## core/src/main/java/kafka/server/share/SharePartition.java: ########## @@ -2405,13 +2424,10 @@ && checkForStartOffsetWithinBatch(inFlightBatch.firstOffset(), inFlightBatch.las lock.writeLock().unlock(); Review Comment: There exists code at line 2439 in this method itself for trigger. So for release, first cache is updated and persister call is just to record correct delivery count. So notification to purgatory is not tied with persister. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org