adixitconfluent commented on code in PR #19612: URL: https://github.com/apache/kafka/pull/19612#discussion_r2071334642
########## core/src/main/java/kafka/server/share/SharePartition.java: ########## @@ -2405,13 +2424,10 @@ && checkForStartOffsetWithinBatch(inFlightBatch.firstOffset(), inFlightBatch.las lock.writeLock().unlock(); Review Comment: should we have a `maybeCompleteDelayedShareFetchRequest` in this finally block as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org