lianetm commented on code in PR #19578:
URL: https://github.com/apache/kafka/pull/19578#discussion_r2068913749
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -1306,7 +1306,10 @@ private Map<TopicPartition, Long>
beginningOrEndOffset(Collection<TopicPartition
// and throw timeout exception if it cannot complete in time.
if (timeout.isZero()) {
applicationEventHandler.add(listOffsetsEvent);
- return listOffsetsEvent.emptyResults();
+ // It is used to align with classic consumer.
+ // When the "timeout == 0", the classic consumer will return
an empty map.
+ // Therefore, the AsyncKafkaConsumer needs to be consistent
with it.
+ return new HashMap<>();
Review Comment:
Should we update the docs for beginning/end offsets in KafkaConsumer.
https://github.com/apache/kafka/blob/fa17bd44b30702fdfa393ae8ce7ab6e3a1f884d8/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java#L1616
Just to clarify that it will return empty if the offsets cannot be retrieved
within the timeout. It's actually a bit confusing because it's not the same
behaviour as in `offsetsForTimes`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
