AndrewJSchofield commented on code in PR #19542:
URL: https://github.com/apache/kafka/pull/19542#discussion_r2064241604
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -3940,8 +3905,12 @@ class KafkaApis(val requestChannel: RequestChannel,
.setCurrentLeader(partitionData.currentLeader)
}
+ private def shareVersion(): ShareVersion = {
+
ShareVersion.fromFeatureLevel(metadataCache.features.finalizedFeatures.getOrDefault(ShareVersion.FEATURE_NAME,
0.toShort))
+ }
+
private def isShareGroupProtocolEnabled: Boolean = {
- config.shareGroupConfig.isShareGroupEnabled
+ config.shareGroupConfig.isShareGroupEnabled ||
shareVersion().supportsShareGroups
Review Comment:
The other part of this of course is that BrokerServer unconditionally
initialises the SharePartitionManager and share coordinator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
