AndrewJSchofield opened a new pull request, #19542: URL: https://github.com/apache/kafka/pull/19542
This PR uses the v1 of the ShareVersion feature to enable share groups for KIP-932. Previously, there were two potential configs which could be used - `group.share.enable=true` and including "share" in `group.coordinator.rebalance.protocols`. After this PR, the first of these is retained, but the second is not. Instead, the preferred switch is the ShareVersion feature. The `group.share.enable` config is temporarily retained for testing and situations in which it is inconvenient to set the feature, but it should really not be necessary, especially when we get to AK 4.2. The aim is to remove this internal config at that point. No tests should be setting `group.share.enable` any more, because they can use the feature (which is enabled in test environments by default because that's how features work). For tests which need to disable share groups, they now set the share feature to v0. The majority of the code changes were related to correct initialisation of the metadata cache in tests now that a feature is used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
