mjsax commented on code in PR #19509:
URL: https://github.com/apache/kafka/pull/19509#discussion_r2059499214


##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/InternalTopicIntegrationTest.java:
##########
@@ -75,7 +75,7 @@
 @Timeout(600)
 @Tag("integration")
 public class InternalTopicIntegrationTest {
-    public static final EmbeddedKafkaCluster CLUSTER = 
EmbeddedKafkaCluster.withStreamsRebalanceProtocol(1);

Review Comment:
   In general yes, but not for `EmbeddedKafkaCluster` -- for 
`EmbeddedKafkaCluster` all unstable features and unstable RPCs are enabled by 
default, so we don't need to do anything in our test code, except using 
`StreamsConfig` to enable it client side.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to