lucasbru commented on code in PR #19509:
URL: https://github.com/apache/kafka/pull/19509#discussion_r2058248210
##########
metadata/src/test/java/org/apache/kafka/metadata/storage/FormatterTest.java:
##########
@@ -368,7 +368,7 @@ public void testInvalidFeatureFlag() throws Exception {
formatter1.formatter.setFeatureLevel("nonexistent.feature",
(short) 1);
assertEquals("Unsupported feature: nonexistent.feature. Supported
features " +
"are: eligible.leader.replicas.version, group.version,
kraft.version, " +
- "share.version, test.feature.version, transaction.version",
+ "share.version, streams.group.featrue,
test.feature.version, transaction.version",
Review Comment:
```suggestion
"share.version, streams.group.feature,
test.feature.version, transaction.version",
```
##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/InternalTopicIntegrationTest.java:
##########
@@ -75,7 +75,7 @@
@Timeout(600)
@Tag("integration")
public class InternalTopicIntegrationTest {
- public static final EmbeddedKafkaCluster CLUSTER =
EmbeddedKafkaCluster.withStreamsRebalanceProtocol(1);
Review Comment:
would we need an admin client to enable the feature now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
