bbejeck commented on code in PR #19544:
URL: https://github.com/apache/kafka/pull/19544#discussion_r2056910733
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManager.java:
##########
@@ -521,11 +521,14 @@ private void onSuccessResponse(final
StreamsGroupHeartbeatResponse response, fin
}
List<StreamsGroupHeartbeatResponseData.Status> statuses =
data.status();
- if (statuses != null && !statuses.isEmpty()) {
- String statusDetails = statuses.stream()
- .map(status -> "(" + status.statusCode() + ") " +
status.statusDetail())
- .collect(Collectors.joining(", "));
- logger.warn("Membership is in the following statuses: {}",
statusDetails);
+ if (statuses != null) {
+ streamsRebalanceData.setStatuses(statuses);
+ if (!statuses.isEmpty()) {
+ String statusDetails = statuses.stream()
+ .map(status -> "(" + status.statusCode() + ") " +
status.statusDetail())
+ .collect(Collectors.joining(", "));
+ logger.warn("Membership is in the following statuses: {}",
statusDetails);
Review Comment:
Why a warn? Seems more like an `INFO`
##########
streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java:
##########
@@ -518,7 +517,7 @@ private void handleStreamsUncaughtException(final Throwable
throwable,
break;
case SHUTDOWN_CLIENT:
log.error(
- "Encountered the following exception during processing and
the registered exception handler" +
+ "Encountered the following exception during processing and
the registered exception handler " +
Review Comment:
```suggestion
"Encountered the following exception during processing
and the registered exception handler" +
```
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##########
@@ -1079,8 +1081,9 @@ public void shutdownToError() {
shutdownErrorHook.run();
}
- public void sendShutdownRequest(final AssignorError assignorError) {
- assignmentErrorCode.set(assignorError.code());
+ public void sendShutdownRequest() {
+ assignmentErrorCode.set(AssignorError.SHUTDOWN_REQUESTED.code());
Review Comment:
Does this mean a shutdown is always considered an error? What about cases
where users proactively shutdown? Or is this only executed in error cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
