lucasbru commented on code in PR #19544:
URL: https://github.com/apache/kafka/pull/19544#discussion_r2057847775
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##########
@@ -1079,8 +1081,9 @@ public void shutdownToError() {
shutdownErrorHook.run();
}
- public void sendShutdownRequest(final AssignorError assignorError) {
- assignmentErrorCode.set(assignorError.code());
+ public void sendShutdownRequest() {
+ assignmentErrorCode.set(AssignorError.SHUTDOWN_REQUESTED.code());
Review Comment:
I do not intend to change the behavior of Kafka Streams here. I believe, the
`SHUTDOWN_REQUESTED` propagated through rebalances is always handled as an
error, yes.
The change in this line doesn't change anything functionally, since we'd
always pass the same `assignorError` to this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
