priyankaku commented on PR #19449: URL: https://github.com/apache/kafka/pull/19449#issuecomment-2808801744
> Thanks for the PR. I cannot find test case about `DataException` in `toConnectData`. Could you also add following case? Thank you. > > ```java > @ParameterizedTest > @ValueSource(strings = { > "{ }", > "{ \"wrong\": \"schema\" }", > "{ \"schema\": { \"type\": \"string\" } }", > "{ \"payload\": \"foo-bar-baz\" }", > "{ \"schema\": { \"type\": \"string\" }, \"payload\": \"foo-bar-baz\", \"extra\": \"field\" }", > }) > public void testNullSchemaContentWithWrongConnectDataValue(String value) { > converter.configure(Map.of(), false); > assertThrows( > DataException.class, > () -> converter.toConnectData(TOPIC, value.getBytes())); > } > ``` I have added this Test case, thanks for suggesting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org