FrankYang0529 commented on code in PR #19449:
URL: https://github.com/apache/kafka/pull/19449#discussion_r2042064492
##########
connect/json/src/test/java/org/apache/kafka/connect/json/JsonConverterTest.java:
##########
@@ -978,6 +978,39 @@ public void testVersionRetrievedFromAppInfoParser() {
assertEquals(AppInfoParser.getVersion(), converter.version());
}
+ @Test
+ public void testSchemaContentIsNull() {
+
converter.configure(Collections.singletonMap(JsonConverterConfig.SCHEMA_CONTENT_CONFIG,
null), false);
+ assertEquals(new SchemaAndValue(Schema.STRING_SCHEMA, "foo-bar-baz"),
converter.toConnectData(TOPIC, "{ \"schema\": { \"type\": \"string\" },
\"payload\": \"foo-bar-baz\" }".getBytes()));
+ }
+
+ @Test
+ public void testSchemaContentIsEmptyString() {
+
converter.configure(Collections.singletonMap(JsonConverterConfig.SCHEMA_CONTENT_CONFIG,
""), false);
Review Comment:
nit: `Collections.singletonMap` -> `Map.of`.
##########
connect/json/src/test/java/org/apache/kafka/connect/json/JsonConverterTest.java:
##########
@@ -978,6 +978,39 @@ public void testVersionRetrievedFromAppInfoParser() {
assertEquals(AppInfoParser.getVersion(), converter.version());
}
+ @Test
+ public void testSchemaContentIsNull() {
+
converter.configure(Collections.singletonMap(JsonConverterConfig.SCHEMA_CONTENT_CONFIG,
null), false);
+ assertEquals(new SchemaAndValue(Schema.STRING_SCHEMA, "foo-bar-baz"),
converter.toConnectData(TOPIC, "{ \"schema\": { \"type\": \"string\" },
\"payload\": \"foo-bar-baz\" }".getBytes()));
+ }
+
+ @Test
+ public void testSchemaContentIsEmptyString() {
+
converter.configure(Collections.singletonMap(JsonConverterConfig.SCHEMA_CONTENT_CONFIG,
""), false);
+ assertEquals(new SchemaAndValue(Schema.STRING_SCHEMA, "foo-bar-baz"),
converter.toConnectData(TOPIC, "{ \"schema\": { \"type\": \"string\" },
\"payload\": \"foo-bar-baz\" }".getBytes()));
+ }
+
+ @Test
+ public void testSchemaContentValidSchema() {
+
converter.configure(Collections.singletonMap(JsonConverterConfig.SCHEMA_CONTENT_CONFIG,
"{ \"type\": \"string\" }"), false);
+ assertEquals(new SchemaAndValue(Schema.STRING_SCHEMA, "foo-bar-baz"),
converter.toConnectData(TOPIC, "\"foo-bar-baz\"".getBytes()));
+ }
+
+ @Test
+ public void testSchemaContentInValidSchema() {
+ assertThrows(
+ DataException.class,
+ () ->
converter.configure(Collections.singletonMap(JsonConverterConfig.SCHEMA_CONTENT_CONFIG,
"{ \"string\" }"), false),
+ " Provided schema is invalid , please recheck the schema you have
provided");
+ }
+
+ @Test
+ public void testSchemaContentLooksLikeSchema() {
+
converter.configure(Collections.singletonMap(JsonConverterConfig.SCHEMA_CONTENT_CONFIG,
"{ \"type\": \"struct\", \"fields\": [{\"field\": \"schema\", \"type\":
\"struct\",\"fields\": [{\"field\": \"type\", \"type\": \"string\" }]},
{\"field\": \"payload\", \"type\": \"string\"}]}"), false);
Review Comment:
ditto
##########
connect/json/src/test/java/org/apache/kafka/connect/json/JsonConverterTest.java:
##########
@@ -978,6 +978,39 @@ public void testVersionRetrievedFromAppInfoParser() {
assertEquals(AppInfoParser.getVersion(), converter.version());
}
+ @Test
+ public void testSchemaContentIsNull() {
+
converter.configure(Collections.singletonMap(JsonConverterConfig.SCHEMA_CONTENT_CONFIG,
null), false);
+ assertEquals(new SchemaAndValue(Schema.STRING_SCHEMA, "foo-bar-baz"),
converter.toConnectData(TOPIC, "{ \"schema\": { \"type\": \"string\" },
\"payload\": \"foo-bar-baz\" }".getBytes()));
+ }
+
+ @Test
+ public void testSchemaContentIsEmptyString() {
+
converter.configure(Collections.singletonMap(JsonConverterConfig.SCHEMA_CONTENT_CONFIG,
""), false);
+ assertEquals(new SchemaAndValue(Schema.STRING_SCHEMA, "foo-bar-baz"),
converter.toConnectData(TOPIC, "{ \"schema\": { \"type\": \"string\" },
\"payload\": \"foo-bar-baz\" }".getBytes()));
+ }
+
+ @Test
+ public void testSchemaContentValidSchema() {
+
converter.configure(Collections.singletonMap(JsonConverterConfig.SCHEMA_CONTENT_CONFIG,
"{ \"type\": \"string\" }"), false);
+ assertEquals(new SchemaAndValue(Schema.STRING_SCHEMA, "foo-bar-baz"),
converter.toConnectData(TOPIC, "\"foo-bar-baz\"".getBytes()));
+ }
+
+ @Test
+ public void testSchemaContentInValidSchema() {
+ assertThrows(
+ DataException.class,
+ () ->
converter.configure(Collections.singletonMap(JsonConverterConfig.SCHEMA_CONTENT_CONFIG,
"{ \"string\" }"), false),
Review Comment:
ditto
##########
connect/json/src/test/java/org/apache/kafka/connect/json/JsonConverterTest.java:
##########
@@ -978,6 +978,39 @@ public void testVersionRetrievedFromAppInfoParser() {
assertEquals(AppInfoParser.getVersion(), converter.version());
}
+ @Test
+ public void testSchemaContentIsNull() {
+
converter.configure(Collections.singletonMap(JsonConverterConfig.SCHEMA_CONTENT_CONFIG,
null), false);
+ assertEquals(new SchemaAndValue(Schema.STRING_SCHEMA, "foo-bar-baz"),
converter.toConnectData(TOPIC, "{ \"schema\": { \"type\": \"string\" },
\"payload\": \"foo-bar-baz\" }".getBytes()));
+ }
+
+ @Test
+ public void testSchemaContentIsEmptyString() {
+
converter.configure(Collections.singletonMap(JsonConverterConfig.SCHEMA_CONTENT_CONFIG,
""), false);
+ assertEquals(new SchemaAndValue(Schema.STRING_SCHEMA, "foo-bar-baz"),
converter.toConnectData(TOPIC, "{ \"schema\": { \"type\": \"string\" },
\"payload\": \"foo-bar-baz\" }".getBytes()));
+ }
+
+ @Test
+ public void testSchemaContentValidSchema() {
+
converter.configure(Collections.singletonMap(JsonConverterConfig.SCHEMA_CONTENT_CONFIG,
"{ \"type\": \"string\" }"), false);
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
