TaiJuWu commented on code in PR #19286:
URL: https://github.com/apache/kafka/pull/19286#discussion_r2043660057
##########
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##########
@@ -237,9 +239,12 @@ public RemoteLogManager(RemoteLogManagerConfig rlmConfig,
this.updateRemoteLogStartOffset = updateRemoteLogStartOffset;
this.brokerTopicStats = brokerTopicStats;
this.metrics = metrics;
+ this.endpoint = endpoint;
+
+ remoteStorageManagerPlugin =
configAndWrapRSMPlugin(createRemoteStorageManager());
Review Comment:
The reason I did not merge this two methods was if we merge them into one,
we will include the configuration step when creating RLMM and RSM in test (we
use `createRemoteStorageManager` in test).
That means we will miss real configuration step in test if merge them
(configuration step should be included in `createRemoteStorageManagerPlugin`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
