ahuang98 commented on code in PR #19454:
URL: https://github.com/apache/kafka/pull/19454#discussion_r2042713587
##########
metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java:
##########
@@ -309,8 +309,10 @@ public void activate() {
long nowNs = time.nanoseconds();
for (BrokerRegistration registration : brokerRegistrations.values()) {
heartbeatManager.register(registration.id(),
registration.fenced());
- heartbeatManager.tracker().updateContactTime(
- new BrokerIdAndEpoch(registration.id(), registration.epoch()),
nowNs);
+ if (!registration.fenced()) {
+ heartbeatManager.tracker().updateContactTime(
Review Comment:
got it! I guess the question should be instead - are we okay that multi-node
clusters can continue to run into the duplicate broker exception. I would say
it's fine given the exception message is more clear now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
