adixitconfluent commented on PR #19261: URL: https://github.com/apache/kafka/pull/19261#issuecomment-2768671007
> Are all scenarios covered in SharePartition unit tests? Hi @apoorvmittal10, I have added the unit tests for different cases of acquire (cached state can be empty/acquire full batch/acquire subset batch). I think a better way to test the added code was through integration tests, hence there I have added plenty in `ShareConsumerTest` since I can mimic transactions and there the code to process aborted transactions is also being tested. Please let me know if this doesn't look enough and I should add more? cc - @AndrewJSchofield -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
