janchilling commented on code in PR #19275:
URL: https://github.com/apache/kafka/pull/19275#discussion_r2024462086
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/StoreChangelogReaderTest.java:
##########
@@ -407,30 +406,6 @@ public long position(final TopicPartition partition) {
}
}
- @ParameterizedTest
- @EnumSource(value = Task.TaskType.class, names = {"ACTIVE", "STANDBY"})
- public void shouldPollWithRightTimeoutWithStateUpdater(final Task.TaskType
type) {
- setupStateManagerMock(type);
- setupStoreMetadata();
- setupStore();
- shouldPollWithRightTimeout(true, type);
- }
-
- @ParameterizedTest
- @EnumSource(value = Task.TaskType.class, names = {"ACTIVE", "STANDBY"})
- public void shouldPollWithRightTimeoutWithoutStateUpdater(final
Task.TaskType type) {
- setupStateManagerMock(type);
- setupStoreMetadata();
- setupStore();
- shouldPollWithRightTimeout(false, type);
- }
-
- private void shouldPollWithRightTimeout(final boolean stateUpdaterEnabled,
final Task.TaskType type) {
- final Properties properties = new Properties();
- properties.put(InternalConfig.STATE_UPDATER_ENABLED,
stateUpdaterEnabled);
- shouldPollWithRightTimeout(properties, type);
- }
-
@ParameterizedTest
@EnumSource(value = Task.TaskType.class, names = {"ACTIVE", "STANDBY"})
public void shouldPollWithRightTimeoutWithStateUpdaterDefault(final
Task.TaskType type) {
Review Comment:
@cadonna Not clear. You mean just change the name of
`shouldPollWithRightTimeoutWithStateUpdaterDefault()` to
`shouldPollWithRightTimeout()` ? or bring back `shouldPollWithRightTimeout()`
as it was earlier?
The reason I removed `shouldPollWithRightTimeout()` method was since
`shouldPollWithRightTimeoutWithStateUpdaterDefault()` also has the same
behavior and they were checking the same thing basically. So redundant code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
