AndrewJSchofield commented on code in PR #19261:
URL: https://github.com/apache/kafka/pull/19261#discussion_r2021223900
##########
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##########
@@ -267,8 +268,20 @@ public CompletableFuture<Map<TopicIdPartition,
PartitionData>> fetchMessages(
.rotate(topicIdPartitions, new
PartitionRotateMetadata(sessionEpoch));
CompletableFuture<Map<TopicIdPartition, PartitionData>> future = new
CompletableFuture<>();
- processShareFetch(new ShareFetch(fetchParams, groupId, memberId,
future, rotatedTopicIdPartitions, batchSize, maxFetchRecords,
brokerTopicStats));
-
+ if (groupConfigManager.groupConfig(groupId).isEmpty()) {
+ processShareFetch(new ShareFetch(fetchParams, groupId, memberId,
future, rotatedTopicIdPartitions, batchSize, maxFetchRecords,
brokerTopicStats));
+ } else {
+ FetchParams updatedFetchParams = new FetchParams(
+ fetchParams.replicaId,
+ fetchParams.replicaEpoch,
+ fetchParams.maxWaitMs,
+ fetchParams.minBytes,
+ fetchParams.maxBytes,
+ FetchIsolation.of(-1,
groupConfigManager.groupConfig(groupId).get().shareIsolationLevel()),
Review Comment:
I think what I object to is using a bare `-1` when there is a specific
constant name for `-1` already in existence. I believe that this parameter is
strictly the replica ID, not really a consumer ID, but it's all a bit mixed up
in `FetchRequest`. We certainly could introduce a `SHARE_CONSUMER_REPLICA_ID` I
suppose, but if it's really just used for this situation, masquerading as a
regular consumer with `CONSUMER_REPLICA_ID` seems fine to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
