jsancio commented on code in PR #19198:
URL: https://github.com/apache/kafka/pull/19198#discussion_r1996104170


##########
docs/upgrade.html:
##########
@@ -72,10 +72,8 @@ <h5><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading 
Servers to 4.0.0 from
         brokers will be running the latest version and you can verify that the 
cluster's behavior and performance meet expectations.
     </li>
     <li>Once the cluster's behavior and performance have been verified, 
finalize the upgrade by running
-        <code>
-            bin/kafka-features.sh --bootstrap-server localhost:9092 upgrade 
--release-version 4.0
-        </code>
-    </li>
+        <code>bin/kafka-features.sh --bootstrap-server localhost:9092 upgrade 
--release-version 4.0</code> 
+        (use <code>--bootstrap-controller</code> when running against a 
controller node).</li>

Review Comment:
   Did you consider linking to the reference documentation for `kafka-features 
upgrade` for a detail explanation of all of the command lined options. 
Otherwise, you end up having to put that disclaimer on every "admin" CLI.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to