m1a2st commented on code in PR #19064: URL: https://github.com/apache/kafka/pull/19064#discussion_r1976535228
########## clients/src/main/java/org/apache/kafka/common/replica/ReplicaSelector.java: ########## @@ -27,6 +27,9 @@ /** * Plug-able interface for selecting a preferred read replica given the current set of replicas for a partition * and metadata from the client. + * Implement {@link org.apache.kafka.common.metrics.Monitorable} to enable the interceptor to register metrics. Review Comment: `to enable the interceptor to register metrics.` should be `to enable the selector to register metrics.` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org