junrao commented on code in PR #19145:
URL: https://github.com/apache/kafka/pull/19145#discussion_r1987833295
##########
server-common/src/main/java/org/apache/kafka/server/storage/log/FetchParams.java:
##########
@@ -85,7 +85,7 @@ public boolean fetchOnlyLeader() {
}
public boolean hardMaxBytesLimit() {
- return requestVersion <= 2;
+ return requestVersion <= 2 && !shareFetchRequest;
Review Comment:
While you are add this, could you also remove the reference to `FetchRequest
version 3` in `ReplicaManager`?
```
// For FetchRequest version 3, we replace incomplete message sets
with an empty one as consumers can make
// progress in such cases and don't need to report a
`RecordTooLargeException`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
