junrao commented on code in PR #19145:
URL: https://github.com/apache/kafka/pull/19145#discussion_r1987795036
##########
server-common/src/main/java/org/apache/kafka/server/storage/log/FetchParams.java:
##########
@@ -85,7 +85,7 @@ public boolean fetchOnlyLeader() {
}
public boolean hardMaxBytesLimit() {
- return requestVersion <= 2;
+ return requestVersion <= 2 && !shareFetchRequest;
Review Comment:
FetchRequest now only supports version 4 and above. It seems that we could
remove `requestVersion` and `hardMaxBytesLimit()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
