kevin-wu24 commented on code in PR #18987:
URL: https://github.com/apache/kafka/pull/18987#discussion_r1968672262


##########
raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java:
##########
@@ -487,6 +555,12 @@ private EventScheduler 
schedulerWithDefaultInvariants(Cluster cluster) {
         return scheduler;
     }
 
+    private EventScheduler schedulerWithKip853Invariants(Cluster cluster) {
+        EventScheduler scheduler = schedulerWithDefaultInvariants(cluster);
+        scheduler.addInvariant(new AtMostOneUncommittedVoterSet(cluster));

Review Comment:
   It can apply to all tests, and perhaps we should be just adding it to the 
default invariant set. I thought it would break the non-KIP-853 tests, so I 
haven't actually tried it yet.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to