dongnuo123 commented on code in PR #18989:
URL: https://github.com/apache/kafka/pull/18989#discussion_r1968009698
##########
core/src/main/scala/kafka/server/BrokerServer.scala:
##########
@@ -645,6 +645,7 @@ class BrokerServer(
.withGroupCoordinatorMetrics(new
GroupCoordinatorMetrics(KafkaYammerMetrics.defaultRegistry, metrics))
.withGroupConfigManager(groupConfigManager)
.withPersister(persister)
+ .withAuthorizer(authorizer.toJava)
Review Comment:
> if we could instead ask the coordinator first for list of topics to filter
out for regex
With the current implementation, the challenge with this is that the
resolution and filtering of the regex are done in an async fashion.
`consumerGroupHeartbeat` will return before we finish resolving the list of
topics to filter which is done in a separate thread in the coordinator.
But it does make sense that it's a bit strange carrying the authorizer to
the coordinator. I think we can work on it as a followup improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
