adixitconfluent commented on PR #18864: URL: https://github.com/apache/kafka/pull/18864#issuecomment-2654516781
Hi @AndrewJSchofield @apoorvmittal10 , the step 3 described above is a little tricky to implement (since we can only know the current assignment, not whether it was calculated by step 1 or step 2). I have implemented a way to filter current assignment as required in step 3 in function `filterCurrentAssignment`, but it is incorrect for a few cases. Maybe step 3 needs more consideration (or a future PR), but can we please meanwhile review the PR in its current state. I can also get rid of step 3 as of now and implement it in a new PR as well. Let me know your thoughts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
