frankvicky commented on code in PR #18737:
URL: https://github.com/apache/kafka/pull/18737#discussion_r1951936120
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareMembershipManager.java:
##########
@@ -83,14 +83,16 @@ public ShareMembershipManager(LogContext logContext,
SubscriptionState subscriptions,
ConsumerMetadata metadata,
Time time,
- Metrics metrics) {
+ Metrics metrics,
+ boolean autoCommitEnabled) {
Review Comment:
> I would say we shouldn't expose this in the ShareConsumer (it doesn't do
auto commits)
Oh, I got it. I will remove this arguments in the next commit.
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareMembershipManager.java:
##########
@@ -83,14 +83,16 @@ public ShareMembershipManager(LogContext logContext,
SubscriptionState subscriptions,
ConsumerMetadata metadata,
Time time,
- Metrics metrics) {
+ Metrics metrics,
+ boolean autoCommitEnabled) {
Review Comment:
> I would say we shouldn't expose this in the ShareConsumer (it doesn't do
auto commits)
Oh, I got it. I will remove this arguments in the next commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
