poom-kitti commented on PR #18018: URL: https://github.com/apache/kafka/pull/18018#issuecomment-2660844921
@dejan2609 Hello, I would include some observations I found, but unsure it would be best practice. It seems to be possible that we can use `shadow` declarable configuration that the [workaround](https://github.com/apache/kafka/pull/15532) tries to solve by creating our own ShadowJar task. A custom ShadowJar task does not add `Class-Path` entry to `MANIFEST.MF`. But we would need to make `shadow` software component uses our custom ShadowJar instead when publishing. I have raised and shown an example here https://github.com/GradleUp/shadow/issues/1252. In our context, if we do go with custom ShadowJar approach, we can remove following: - No longer needed to loop through removing dependencies that are currently declared as `shadowed` in ShadowJar task as we will declare them as `shadow` instead - No longer needed to prevent generation of Gradle module metadata nor modify POM file generation ourselves as `shadow` software component already configured the metadata correctly to include dependencies declared as `shadow` to be runtime scope -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
