loicgreffier commented on PR #18739: URL: https://github.com/apache/kafka/pull/18739#issuecomment-2629424022
@cadonna Thank you for the guidance. I could trigger the `InMemoryTimeOrderedKeyValueChangeBuffer#flush` and `InMemoryTimeOrderedKeyValueChangeBuffer#restoreBatch` and confirm that the `rawKey` and `rawValue` are lost. Please ignore my previous comment https://github.com/apache/kafka/pull/18739#discussion_r1937172436 that brings too many changes. I've updated the serialization and deserialization. To take into consideration the optional rawKey and rawValue, I've added a char "marker" (i.e., `k` for rawKey, `v` for rawValue) to identify the presence of these values without mixing with any other possible bytes. Let me know your thoughts about this approach -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
