lucasbru commented on code in PR #18705:
URL: https://github.com/apache/kafka/pull/18705#discussion_r1935634947
##########
streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java:
##########
@@ -960,126 +960,65 @@ KTable<K, V> toTable(final Named named,
final Materialized<K, V, KeyValueStore<Bytes,
byte[]>> materialized);
/**
- * Group the records of this {@code KStream} on a new key that is selected
using the provided {@link KeyValueMapper}
- * and default serializers and deserializers.
+ * Group the records by their current key into a {@link KGroupedStream}
while preserving the original values.
* {@link KGroupedStream} can be further grouped with other streams to
form a {@link CogroupedKStream}.
- * Grouping a stream on the record key is required before an aggregation
operator can be applied to the data
- * (cf. {@link KGroupedStream}).
- * The {@link KeyValueMapper} selects a new key (which may or may not be
of the same type) while preserving the
- * original values.
- * If the new record key is {@code null} the record will not be included
in the resulting {@link KGroupedStream}
- * <p>
- * Because a new key is selected, an internal repartitioning topic may
need to be created in Kafka if a
- * later operator depends on the newly selected key.
- * This topic will be named "${applicationId}-<name>-repartition",
where "applicationId" is user-specified in
- * {@link StreamsConfig} via parameter {@link
StreamsConfig#APPLICATION_ID_CONFIG APPLICATION_ID_CONFIG},
+ * (Co-)Grouping a stream on the record key is required before a windowing
or aggregation operator can be applied
+ * to the data (cf. {@link KGroupedStream}).
+ * If the grouping key is {@code null} the record will be dropped.
Review Comment:
`grouping key` is not mentioned before. In the context of this method, it's
just the key, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
