mjsax commented on code in PR #18705: URL: https://github.com/apache/kafka/pull/18705#discussion_r1929509438
########## streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java: ########## @@ -960,126 +960,65 @@ KTable<K, V> toTable(final Named named, final Materialized<K, V, KeyValueStore<Bytes, byte[]>> materialized); /** - * Group the records of this {@code KStream} on a new key that is selected using the provided {@link KeyValueMapper} - * and default serializers and deserializers. Review Comment: Default serdes from the config are `null` now... Also, we should actually inherit form upstream first... Somewhat outdate. Removing it here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org