AndrewJSchofield commented on code in PR #18735: URL: https://github.com/apache/kafka/pull/18735#discussion_r1934315177
########## clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java: ########## @@ -1783,12 +1782,14 @@ public void testDescribeTopicsWithDescribeTopicPartitionsApiErrorHandling() thro } } - @Flaky("KAFKA-18441") @Test public void testAdminClientApisAuthenticationFailure() { Cluster cluster = mockBootstrapCluster(); try (final AdminClientUnitTestEnv env = new AdminClientUnitTestEnv(Time.SYSTEM, cluster, - newStrMap(AdminClientConfig.REQUEST_TIMEOUT_MS_CONFIG, "1000"))) { + newStrMap(AdminClientConfig.REQUEST_TIMEOUT_MS_CONFIG, "1000", + // The default "retry.backoff.ms" is 100. if following assertion can't finish in 100L, + // the test will fail. Set it to 5000 to make sure the test can finish in time. + AdminClientConfig.RETRY_BACKOFF_MS_CONFIG, "5000"))) { env.kafkaClient().setNodeApiVersions(NodeApiVersions.create()); env.kafkaClient().createPendingAuthenticationError(cluster.nodes().get(0), TimeUnit.DAYS.toMillis(1)); Review Comment: Thanks for the description. I've approved the PR and will merge once the build is complete. However, my question really was whether this is desirable behaviour. I would say that the original author intended to "pin" the authentication failure to last for a day so that all operations failed and a multi-part test could be performed reliably. Something has changed over the past couple of months making this unreliable. So, I expect there's a follow-on piece of work in here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org